feat: add default variant to Alert and Badge #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
reviewed
Oct 1, 2020
jquense
reviewed
Oct 1, 2020
davidjb
changed the title
davidjb
added a commit
to davidjb/react-bootstrap
that referenced
this pull request
Oct 1, 2020
This bugfix aligns the `<button>` variant class implementation with Alert/Badge/Navbar -- only outputing a `prefix-variant` formatted class when a variant is specified and avoiding the situation of outputting `.btn-null` or `.btn-` when the variant is null or an empty string respectively Split from react-bootstrap#5456
davidjb
force-pushed
the
default-variant
branch
from
3318a90
to
4bc3e13
Compare
davidjb
changed the title
jquense
pushed a commit
that referenced
this pull request
Oct 1, 2020
This bugfix aligns the `<button>` variant class implementation with Alert/Badge/Navbar -- only outputing a `prefix-variant` formatted class when a variant is specified and avoiding the situation of outputting `.btn-null` or `.btn-` when the variant is null or an empty string respectively Split from #5456
|
Sounds good to me. Let's push it to v5 |
I would agree on that as well. |
|
@davidjb, sorry for the delay on this. Can you rebase this and change Thanks! |
This sets a default variant and bg of "primary" for Alert and Badge respectively, allowing them to be used without having to set a variant or bg. Bootstrap's docs on Alerts require the use of a contextual class (https://getbootstrap.com/docs/5.1/components/alerts/) in order to have proper styling. This aligns Alert and Badge variant functionality with that of Button and Navbar. This could be viewed as a breaking change (e.g. for someone using Alert without a variant [as it now adds one] or someone relying on Button's `.btn-null` [if the variant was null]). However, I'm inclined to view this as a feature as it is adding & declaring functionality in the public API where behaviour wasn't previously explicitly defined in examples or docs.
davidjb
force-pushed
the
default-variant
branch
from
4bc3e13
to
f5bf34b
Compare
|
@kyletsang Done! That should be it - rebased, updated the Badge and its tests, plus updated commit message. In v5.x, the Badge is particularly important to have a default bg because its text is white, making it unreadable on a standard background. At least in 4.x it was black text by default. |
kyletsang
approved these changes
Aug 9, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets a default variant of "primary" for Alert and Badge, allowing them to be used without having to set a variant. Bootstrap's docs on Alerts/Badges require the use of a contextual class (https://getbootstrap.com/docs/4.5/components/alerts/) in order to have proper styling.
This aligns Alert and Badge variant functionality with that of Button and Navbar, where default variants are provided and can be used like
<Button>Hello</Button>.This could be viewed as a breaking change (e.g. for someone using Alert without a variant as it now adds one). However, it could be viewed as a feature as it is adding & declaring functionality in the public API where behaviour wasn't previously explicitly defined in examples or docs.