Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://v5.getbootstrap.com/docs/5.0/components/dropdowns/
Added the dark dropdown variant initially.
Changes:
I noticed that Bootstrap changed their dropdown menu/item markup back to using ul/li in twbs/bootstrap#28591 . We should probably do the same here. I wanted to get some feedback before adding those changes though. In
DropdownItem
, I could make it so the props control theli
element, then apply the anchor specific props/classes to the inner anchor... but then this probably need additional props to control rendering of the anchor. Alternatively, add a bareli
wrapping element and keep the current implementation as is?