Docs unordered lists dropdowns #28591
Conversation
Replace snippets and examples in dropdown docs to use semantic ul and li elements.
Replace dropdown snippets and examples in navbar docs to use semantic ul and li elements.
Mention in the dropdown examples paragraph that custom markup is supported even though shown examples use ul’s.
|
i'd just mention that "compliance with the WAI-ARIA standard" is not a thing. this has nothing to do with ARIA, as these aren't aria menus or anything else other than a series of links. while the use of unordered lists here would be my personal preference as well, it's not necessarily wrong not to have them in a list, and wouldn't be, say, a hard fail of WCAG 1.3.1 either... |
|
Moving the divider into the <ul class="dropdown-menu" aria-labelledby="navbarDropdown">
<li><a class="dropdown-item" href="#">Action</a></li>
<li><hr class="dropdown-divider"></li>
<li><a class="dropdown-item" href="#">Another action</a></li>
</ul>Or <ul class="dropdown-menu" aria-labelledby="navbarDropdown">
<li><a class="dropdown-item" href="#">Action</a></li>
<li><div role="separator" class="dropdown-divider" /></li>
<li><a class="dropdown-item" href="#">Another action</a></li>
</ul>The first example above would be most semantically correct without the need of a |
|
@bittner I'm clearing out some of your comments here—one is enough. 😅 You can also batch your comments in the future as a single review to reduce comment notifications and noise :). |
I'm sorry! 😏 I was really just trying to help by marking the related places. 💩 And, yes you're right. |
Replace snippets and examples in dropdown docs to use semantic ul and li elements.
Replace dropdown snippets and examples in navbar docs to use semantic ul and li elements.
Mention in the dropdown examples paragraph that custom markup is supported even though shown examples use ul’s.
…atherraptor/bootstrap into docs-unordered-lists-dropdowns
Move dropdown-divider class onto hr inside list item instead of on list item itself
…into docs-unordered-lists-dropdowns
|
Feedback addressed! I seem to have gotten my commits all in a tizzy (bit of a forking rookie) so sorry. Should probably squash |
There was a problem hiding this comment.
LGTM. @patrickhlauke, could you have a look at the latest changes here?
|
@patrickhlauke: ping |
Fixes #25728.
Documentation should suggest semantic
ulandlielements in the dropdowns and navbar components to encourage semantic HTML markup. Added a mention that while examples here depict semanticulelements custom markup is supported.