refactor(Dropdown)!: simplify menu alignment API #5759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the menu alignment API by consolidating
alignRight
andmenuAlign
props into a singlealign
prop that's exposed on the Dropdown and DropdownMenu components.A couple breaking changes in here:
alignRight
from Dropdown and DropdownMenumenuAlign
from DropdownButton and SplitButtonAlso fixed a couple of things I noticed while refactoring:
data-bs-popper
to the DropdownMenu. Bootstrap now uses this attribute in their css to do the alignment