Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SURVEY: Should we still support IE8? (WE NEED FEEDBACK) #692

Closed
AlexKVal opened this issue May 18, 2015 · 33 comments
Closed

SURVEY: Should we still support IE8? (WE NEED FEEDBACK) #692

AlexKVal opened this issue May 18, 2015 · 33 comments
Labels

Comments

@AlexKVal
Copy link
Member

Honestly I propose to abandon IE8 support.

The library becomes more and more complicated and it is already using ES6 (and JSX+ES7) code,
that is hard to make work in IE8.

More and more other projects drop IE8 maintenance burden because - honestly at 2015 - there is no value in it.

However if there is enough interest to support and maintain code for IE8,
here are my notes:

npm run ie8 command doesn't work because of
Error: Cannot find module 'webpack-dev-middleware'

Some files like ie8/package.json
are not used at all. (at least since grunt => npm scripts)

For those who are interested here is The Inception (it's not the famous movie 😄 )

Additional benefit - if we drop IE8 support - we can easier remove jQuery dependency.

@krzysiek1507
Copy link
Contributor

+1 for drop IE8 support ;)

@mtscout6
Copy link
Member

👍 I too am in favor of this as my company has not supported IE8 for over a year, without much grumbling from our customers. Many of which are corporate entities.

With that said though we are marrying both React and Bootstrap, and both support IE8:

The real question would come down to who's using this and who cares that it's still supported?

@mtscout6 mtscout6 changed the title IE8 state of affairs SURVEY: Should we still support IE8? (WE NEED FEEDBACK) May 18, 2015
@mtscout6
Copy link
Member

CC'ing All past contributors for more feedback on this.

/cc @stevoland
@pieterv
@taion
@trentgrover-wf
@dozoisch
@apkiernan
@stereosteve
@teloo
@aabenoja
@aforty
@brainary
@smbecker
@jquense
@kellec
@mfunkie
@cymen
@RichardLitt
@defrex
@zeroedin-bill
@tacomanator
@glenjamin
@liamcmitchell
@chollier
@KnisterPeter
@martijnvermaat
@mattly
@computmaxer
@tracker1
@ronjouch
@sahat
@stefanfisk
@stevie-mayhew
@thetimbanks
@kroepke
@amarant
@bobpace
@cassus
@cvrebert
@cdock1029
@limscoder
@davidbgk
@dkastner
@EricWarnke
@cell303
@lipsmack
@yeojz
@hcarvalhoalves
@thehuey
@justjake
@jamesakers
@time4tea
@JamesTrigg
@jeroencoumans
@jingchan
@joemcbride
@jonasoberschweiber
@odetown
@lucasfrey
@lo1tuma
@mathieumg
@gldnspud
@heydiplo
@raine
@randylien
@rtsao
@scottwoodall
@gitter-badger
@traviscooper
@vinnymac
@YannPl
@alasdaircs
@lilaja
@mgechev
@mtetlow
@DJCordhose
@skv-headless
@staeff

@stefanfisk
Copy link
Contributor

for the last year or so, after showing customer their own visitors stats, none have wanted to pay for the extra work required for IE8 support, so I'd say drop it if there's any reason whatsoever.

@aforty
Copy link
Contributor

aforty commented May 18, 2015

I just spent a few minutes writing a few reasons for keeping it but... +1 for dropping support.

@mathieumg
Copy link
Member

we are marrying both React and Bootstrap, and both support IE8

I came here to point that out, glad you already did! I personally am not adamant about keeping it. However, if we were to, do we have an outline of the implications other than the lost benefits mentioned in @AlexKVal 's post?

@glenjamin
Copy link
Collaborator

It's not in my support grid at work, so not something I'm bothered about.

@ronjouch
Copy link
Contributor

Am using react-bootstrap at work for a new ticket purchasing app. Even in this non-techie, very business-y environment where every dollar drop counts, our minimum IE is IE9 and there's wasn't any debate on not supporting IE8. As already mentioned by other commenters, there isn't much left to squeeze, and maintenance costs.

+1 to drop.

@mattly
Copy link
Contributor

mattly commented May 18, 2015

I hope to never use bootstrap again. Please do not ping me for future issues.

@tacomanator
Copy link
Contributor

+1 for dropping, with the following rationale:

  1. Apparently it will be dropped in Bootstrap 4 anyway.
  2. I guess that a vast majority of projects using react-bootstrap are not built with IE8 in mind.
  3. If desired someone could maintain it as a fork, which need not keep support up-to-date with each and every release of react-bootstrap core (could be batched).

@martijnvermaat
Copy link
Contributor

+1 for dropping

@jquense
Copy link
Member

jquense commented May 18, 2015

While I don't personally or professionally need ie8 support I think that as long as both React and Bootstrap support it then react-bootstrap should as well. My experience supporting ie8 in react component libraries (react-widgets) is that React makes supporting ie8 fairly simple, and has only added a bit of code overall. The main areas being cases where you need to circumvent the react event system, and style/position issues. TBH mobile Safari has been much more of a headache to support than IE8

I would think that unless there is a reasonable incentive not too (lots of extra bytes, not feasible, time cost, etc) we should keep ie8 support, even if it is only in a "we don't test super strongly but will fix reported bugs in ie8" capacity. That being said IE8 testing is a huge pain and if maintaining it is gonna be a burden on the maintainers, I'd much prefer that time be spent elsewhere :)

@dozoisch
Copy link
Member

I'm not going to debug in IE8 anyway! +1 for dropping.

And Microsoft is dropping IE8 support in 6 months.
http://blogs.msdn.com/b/ie/archive/2014/08/07/stay-up-to-date-with-internet-explorer.aspx?utm_medium=referral&utm_source=pulsenews

@mfunkie
Copy link
Member

mfunkie commented May 18, 2015

I'm okay with dropping IE8 as we don't even support IE9 in our internal CRM where we use React Bootstrap.

There is something to be said for IE8 support being in parity with React itself though.

@luisrudge
Copy link

👍 for dropping support.

@thetimbanks
Copy link
Contributor

+1 for dropping IE8 support due to support being dropped in BS4 and
Microsoft dropping support.

On Monday, May 18, 2015, Luís Rudge notifications@github.com wrote:

[image: 👍] for dropping support.


Reply to this email directly or view it on GitHub
#692 (comment)
.

@taion
Copy link
Member

taion commented May 18, 2015

My thoughts match @jquense. I have no need to support IE8 for any reason, but as long as both upstreams support it and it's a relatively small amount of work, then I think it makes sense to retain some (potentially somewhat degraded) support, to the extent that it doesn't get in the way too badly.

@stereosteve
Copy link
Contributor

I did some of the initial work adding IE8 support, but we ended up not using react-bootstrap at work, so 👍 for dropping.

@sahat
Copy link
Contributor

sahat commented May 18, 2015

I would just drop it and not bother with IE8.

@thehuey
Copy link
Contributor

thehuey commented May 18, 2015

[image: Inline image 1]

On Mon, May 18, 2015 at 11:32 AM, Sahat Yalkabov notifications@github.com
wrote:

I would just drop it and not bother with IE8.


Reply to this email directly or view it on GitHub
#692 (comment)
.

@dbackeus
Copy link

+1 to drop

@stevie-mayhew
Copy link
Contributor

I think that we have to support it while the upstream supports it. In saying that, this may just be the case of only fixing issues which are reported rather than actively maintaining and testing for IE8.

Once one of the upstreams no longer support IE8 or Microsoft drops IE8 support then I am all for it. In saying that, we do not support IE8 by default either.

@RichardLitt
Copy link
Contributor

Drop it.

On Tue, May 19, 2015 at 2:15 AM, Stevie Mayhew notifications@github.com
wrote:

I think that we have to support it while the upstream supports it. In
saying that, this may just be the case of only fixing issues which are
reported rather than actively maintaining and testing for IE8.

Once one of the upstreams no longer support IE8 or Microsoft drops IE8
support then I am all for it. In saying that, we do not support IE8 by
default either.


Reply to this email directly or view it on GitHub
#692 (comment)
.

Richard | @richlitt https://twitter.com/richlitt | burntfen.com
http://www.burntfen.com

@KnisterPeter
Copy link
Contributor

+1 for dropping from me too

@teloo
Copy link
Contributor

teloo commented May 18, 2015

+1 for dropping support.

@kroepke
Copy link
Contributor

kroepke commented May 19, 2015

Our product never actually worked on IE8, so we are more than fine with dropping it 👍

@billschaller
Copy link

I have a few very large institutional clients on one of our main apps that are still in the process of phasing out IE8, so I do still need to support it.

@tracker1
Copy link
Contributor

+1 to drop ... it's time for it to die (about 0.5% of our users).

@tacomanator
Copy link
Contributor

Another point I just thought about. As I understand it dropping IE8 support will only affect a small number of features provided by Bootstrap. Furthermore, even if those features are technically "broken" it doesn't necessarily mean the resulting site is completely unusable. I think it's important to make this distinction for some people that may be on the fence.

@yeojz
Copy link
Contributor

yeojz commented May 21, 2015

+1 for dropping it, mainly due to the fact that Bootstrap 4 is moving in that direction.

Maybe affected components can be moved out of the "core" library into a separate "support" library if IE8 support is still needed. But this will probably be too time consuming.

Personally though, haven't really had IE8 requirements recently.

@pedroteixeira
Copy link

Currently, most projects have to support only >=IE9.
is there any jQuery dependency? wasn't aware.. (it's not in package.json for instance)

Nevetherless, what feature you think would break in IE8 that cannot be solved with shims/polyfills? I think breaking direct/source-code support is fine, but it would be nice to point others in the docs which features (hence polyfills) are assumed/required from browser.

@thealjey
Copy link
Contributor

+1 to drop support for the dreaded IE8

@mtscout6
Copy link
Member

I wanted to thank all of you for your feedback it has been most appreciated.

I’m leaning towards the suggestions by a few of you to only support IE8 so far as folks submit PRs to fix it. However, it should be warned that Bootstrap is planning to drop support for IE8 when they drop v4 on us as stated in http://blog.getbootstrap.com/2014/10/29/bootstrap-3-3-0-released/#onward-to-bootstrap-4. I’m thinking that inline with what the Bootstrap team is doing we will likely plan to still provide some limited support for Bootstrap 3.x once 4.0 is out and while we adjust to whatever breaking changes they throw at us.

With that said though I think any IE8 debugging can happen within the confines of our existing docs infrastructure, so I'd propose that we remove the ie8/ folder from our repo.

Also going forward if we notice any code that is IE8 specific we should mark it with a comment like // Only for IE8 that way we can easily know what can be removed when we start the Bootstrap v4 migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests