Pass Nav props to ul so css classes can be applied #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,7 @@ var Nav = React.createClass({ | |||
| classes['nav-justified'] = this.props.justified; | |||
| classes['navbar-nav'] = this.props.navbar; | |||
|
|
|||
| return ( | |||
| return this.transferPropsTo( | |||
There was a problem hiding this comment.
The this.transferPropsTo will need to me moved to L49 so that line would end up looking like:
return this.transferPropsTo(this.renderUl());In its current position for the non navbar use-case it would end up transferring all props to both the nav and the ul.
|
Hey @scottwoodall thanks for the PR, sorry my comment in #101 wasn't particularly clear on what was needed, but looks like we are on the right path now :) |
|
Thank you for the feed back. I've made your suggested changes. Let me know if I misunderstood or you'd like to see something else. |
|
This is perfect! If you squash the commits i will merge it in :) |
|
Awesome! |
pieterv
added a commit
that referenced
this pull request
Jun 15, 2014
Pass Nav props to ul so css classes can be applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @pieterv #101 (comment)