[added] Images Component with Sample and Docs #1293
Conversation
| thumbnail: React.PropTypes.bool | ||
| }, | ||
|
|
||
| getDefaultProps() { |
There was a problem hiding this comment.
I thought our prop tables were generated off prop types, not default props.
There was a problem hiding this comment.
Thank you @taion for the review. Does it mean the getDefaultProps() method is not needed here?
|
See inline comments. Also, we'd want this squashed into a single commit with a comment like: |
deerawan
force-pushed
the
images-component
branch
from
02d1e3d
to
e7706bb
Compare
image testing done add docs add comment for props * Merge previous three samples (ImageCircle, ImageRounded, ImageThumbnail) to one sample file (ImageShape) * Add ImageResponsive and ImageShape in ReactPlayground.js * Add Image source include in Samples.js fix the comment * Fix eslint issue on Image.js * Fix eslint issue on ImageSpec.js * remove src and alt * refactor test code to test attribute not props fix eslint
deerawan
force-pushed
the
images-component
branch
from
e7706bb
to
674d67e
Compare
|
LGTM. I'm fine to place it to the end of Need one more sign of @react-bootstrap/collaborators Docs part looks like:
|
|
LGTM, but would we be okay with putting this above "Utilities" at least? |
|
Ok. Then I merge it and I will move it upper and fix eslint warnings fixing because of #1335. |
[added] Images Component with Sample and Docs
|
@AlexKVal thanks for your fixing :) |
|
Np 🍒 |
|
Thank you @deerawan for contributing to this project ✨ ❇️ |
Create an images component as refer to http://getbootstrap.com/css/#images including samples and docs.