Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for React 0.14.0-rc1 and React Router 1.0.0-rc1 #1319

Merged
merged 2 commits into from
Sep 13, 2015

Conversation

taion
Copy link
Member

@taion taion commented Sep 12, 2015

Going to cut react-bootstrap@0.25.102-react-pre.0 after this.

@AlexKVal
Copy link
Member

I'm not sure if this warning has an importance for update. Could be fixed later o/c. Insignificant.
screen shot 2015-09-13 at 12 09 59 am

Everything seems working. Routing, Components.
LGTM

p.s. React-0.14 helps to discover some minor errors on the Components page, but they are for another PR o/c
screen shot 2015-09-13 at 12 15 29 am

@taion
Copy link
Member Author

taion commented Sep 12, 2015

I didn't see that error. Will take a look.

@AlexKVal
Copy link
Member

I've rechecked:

> git checkout pr/1319
> rm -rf node_modules && npm i
> npm run docs
> open http://localhost:4000/components.html

there are all those warnings in the dev. console.
Full page reload - and they are still exist.

@taion
Copy link
Member Author

taion commented Sep 13, 2015

I'm seeing a mismatch between

(server)

<button id="bg-vertical-dropdown-1" class="dropdown-toggle btn btn-default" type="button" aria-haspopup="true" aria-expanded="false" data-reactid=".22v56e0purk.1.0.2.0.0.1.h.0.0.0.2.$/=10">

and

(client)

<button aria-expanded="false" aria-haspopup="true" class="dropdown-toggle btn btn-default" type="button" id="bg-vertical-dropdown-1" data-reactid=".22v56e0purk.1.0.2.0.0.1.h.0.0.0.2.$/=10">

This is really weird but I don't think it's a blocker, so I'm going to release.

taion added a commit that referenced this pull request Sep 13, 2015
Update for React 0.14.0-rc1 and React Router 1.0.0-rc1
@taion taion merged commit 8f153f6 into react-bootstrap:react-14 Sep 13, 2015
@taion taion deleted the r14-rc1 branch September 13, 2015 15:20
@jquense
Copy link
Member

jquense commented Sep 13, 2015

Do we think this may be a react bug? worth mentioning it their issue tracker?

@taion
Copy link
Member Author

taion commented Sep 13, 2015

The really weird thing is that it's not consistently reproducible. This only seems to happen the first time I hit that page, but not the second. I don't know.

@AlexKVal
Copy link
Member

Yeah.. After you had mentioned this, I've noticed it too:
it is not consistently reproducible indeed. Some weird subtle bug 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants