Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The continuation of #1273
#1273 (comment) here is my fixes for it
[fixed] Breadcrumb and BreadcrumbItem components (the second commit in this PR)
Looking into it more rigorously:
active
property is not needed if stated functionality is implementedAutosetting
navItem
property ontoBreadcrumb
children - also is copy/past leftovers.Both
id
andlinkId
have to bestring
ornumber
types instead juststring
(to comply with other components).Notice
This implementation (of
BreadcrumbItem
) has the same weak spots as some other components have too.className
applies only onto wrapper componenthref
,target
title
it is possible to set for inneranchor
element.style
orclassName
properties to innera
orspan
elements.etc.
It looks now as: