Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle button in collapsed Navbar works again. #154

Merged
merged 1 commit into from
Jul 19, 2014
Merged

Toggle button in collapsed Navbar works again. #154

merged 1 commit into from
Jul 19, 2014

Conversation

brainary
Copy link
Contributor

As isOpen and isCollapsable was changed (to expanded and collapsable) in CollapsableMixin the new props needs to be used to get the collapsed Navbar working again.

I get some graphical glitches on Chrome37/Win7 though, that I'm not smart enough to fix;

  • Expanded state shows a scroll bar with 1px scroll space.
  • Clicking fast on the toggle button locks it in place, any additional clicks won't expand/collapse the Navbar.

No errors on IE11/Win7

Best way to test is to go to the docs page and contract the window till the Navbar collapses.

@pieterv
Copy link
Contributor

pieterv commented Jul 19, 2014

Awesome work!

Ill merge this in and we can look at the additional issues after :)

pieterv added a commit that referenced this pull request Jul 19, 2014
Toggle button in collapsed Navbar works again.
@pieterv pieterv merged commit a2f4bd8 into react-bootstrap:master Jul 19, 2014
@brainary brainary deleted the navbar-collapse branch July 19, 2014 10:38
aryad14 pushed a commit to aryad14/react-bootstrap that referenced this pull request Oct 11, 2023
aryad14 pushed a commit to aryad14/react-bootstrap that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants