Clarify naming expectation for glyph prop #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not immediately obvious to remove the prefix since we specify using the icon name with a link to bootstrap which does use the prefix. It was only after looking at the sample and my written code that I noticed the difference.
|
LGTM thanks! |
|
@jquense When looking through the documentation, It looked as if the docs were built off the annotations which is what I have updated. I noticed that the docs at https://react-bootstrap.github.io/ still don't show the updated description. Are those docs built and updated separate from the pull requests or was there something else that I needed to update for the change to show? |
|
@sidewaysgravity the docs site isn't deployed automatically on a PR, we have to actually manually trigger a deploy for it. So no worries on your end, we jsut haven't pushed the update out yet. |
|
@jquense Cool. No rush on it, I just wanted to make sure I didn't miss something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not immediately obvious to remove the prefix since we specify using the icon name with a link to bootstrap which does use the prefix. It was only after looking at the sample and my written code that I noticed the difference.
While its nothing major I feel that this just adds a bit of clarity to the naming convention.