Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SafeAnchor a11y - Provide keydown handler for "space" #2697

Merged
merged 5 commits into from Aug 26, 2017
Merged

SafeAnchor a11y - Provide keydown handler for "space" #2697

merged 5 commits into from Aug 26, 2017

Commits on Jul 10, 2017

  1. Provide keydown handler for "space" 

    If `onKeyDown` prop is supplied, prefer that
If no `onKeyDown` supplied, handle "space" with the `onClick` handler.
Test that space bar calls click handler.
    AJD committed Jul 10, 2017
    Configuration menu
    Copy the full SHA
    2f88092 View commit details
    Browse the repository at this point in the history

  2. Check for key, not keycode

    AJD committed Jul 10, 2017
    Configuration menu
    Copy the full SHA
    aac3d06 View commit details
    Browse the repository at this point in the history

  3. Only add handler if rendering a tag 

    Chain own-props `onKeyDown` with space handler
    AJD committed Jul 10, 2017
    Configuration menu
    Copy the full SHA
    831dbd2 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2017

  1. Prevent default only for space, don't check for a

    AJD committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    b8800db View commit details
    Browse the repository at this point in the history

  2. Style nits

    @taion
    taion committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    b297dd5 View commit details
    Browse the repository at this point in the history