Forward ref #3080
Merged
Forward ref #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that intuitive? Maybe something like |
Well those are just normal props, wondering if it makes sense to leaverage that we can make I am not sure if it's intuitive, I think that depends on how the ecosystem adjusts to the new API |
|
Hmm... fair enough. I wonder if this might make tests harder. Maybe it doesn't matter. |
jeffreyroshan
added a commit
to jeffreyroshan/react-bootstrap
that referenced
this pull request
Mar 26, 2018
* v4-support: (43 commits) quick fix-up on BreadcrumbItem (react-bootstrap#3090) Add v4 support for Jumbotron (react-bootstrap#3064) Breadcrumbs (react-bootstrap#3050) Update logo to svg (react-bootstrap#3088) navbar (react-bootstrap#3082) Forward ref (react-bootstrap#3080) Navs (react-bootstrap#3062) Add v4 support for tables (react-bootstrap#3070) Add v4 support for images and figures (react-bootstrap#3059) Set sideEffects to false for webpack 4 (react-bootstrap#3075) Style context (react-bootstrap#3046) Gatsby v2 (react-bootstrap#3045) fix readme, react-16-enzyme doc running (react-bootstrap#3061) update to babel 7 (react-bootstrap#3044) attribute docs (react-bootstrap#3035) Update dependencies (react-bootstrap#3020) Fix type in README.md Changed ProgressBar check to work with proxied components (react-bootstrap#2965) Improve custom overlays docs (react-bootstrap#2998) Release v0.32.1-docs.0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we should go a step further and forward it through to the component so it can be attached directly to the DOM node?