Update CollapsableParagraph.js #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using classNames
|
The examples are evaled at runtime which is what allows you to change them in the code tab and see live updates. This also means that we have some variables pre-defined for the examples. |
mtscout6
added a commit
that referenced
this pull request
Apr 8, 2015
This has been causing a lot of confusion for folks since React has
depricated `classSet`. We felt at the time that changing the require
call to `require('classnames')` withing changing the variable name would
be enough. It hasn't due to the confusion people are seeing.
Fixes #489
|
Noted. It'd be nice that this was clearer (classSet >> classNames) as it seems a bit a misleading in the example. Thanks. |
|
I understand, that's why I followed up with 6dfcf36 😄 |
aryad14
pushed a commit
to aryad14/react-bootstrap
that referenced
this pull request
Oct 11, 2023
…strap#489) * fix(package): update prop-types to version 15.7.0 * chore(package): update lockfile package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using classNames