Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix types for event key #5727

Merged
merged 1 commit into from
Mar 19, 2021
Merged

fix(types): fix types for event key #5727

merged 1 commit into from
Mar 19, 2021

Conversation

kyletsang
Copy link
Member

This fixes a number of type inconsistencies surrounding event keys. The types were changed to allow string and number only.

@kyletsang kyletsang requested a review from jquense March 18, 2021 18:03
@kyletsang kyletsang added this to In Progress in v5 support via automation Mar 18, 2021
Copy link
Member

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kyletsang kyletsang merged commit 6260997 into bs5-dev Mar 19, 2021
v5 support automation moved this from In Progress to Done Mar 19, 2021
@kyletsang kyletsang deleted the types/eventkey branch March 19, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5 support
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants