Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds Carousel no transition example #6397

Merged

Conversation

mateusbw
Copy link
Contributor

@mateusbw mateusbw commented Jul 7, 2022

Ref: #6266

Adds a No animation transition carousel example to the docs.

@mateusbw mateusbw changed the title Add Carousel no transition example Adds Carousel no transition example Jul 7, 2022
@mateusbw mateusbw changed the title Adds Carousel no transition example docs: adds Carousel no transition example Jul 7, 2022
Copy link
Member

@kyletsang kyletsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos to fix but looks good

@@ -37,6 +38,12 @@ Add the `fade` prop to your carousel to animate slides with a fade transition in

<ReactPlayground codeText={CarouselFade} />

## No transation animation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## No transation animation
## No transition animation

@@ -37,6 +38,12 @@ Add the `fade` prop to your carousel to animate slides with a fade transition in

<ReactPlayground codeText={CarouselFade} />

## No transation animation

Set the `slide` prop to false to disable the transation animation between slides.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Set the `slide` prop to false to disable the transation animation between slides.
Set the `slide` prop to `false` to disable the transition animation between slides.

@kyletsang kyletsang merged commit d118898 into react-bootstrap:master Jul 15, 2022
@kyletsang
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants