Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: migrate to Algolia DocSearch v3 #6410

Merged
merged 2 commits into from
Jul 29, 2022
Merged

docs: migrate to Algolia DocSearch v3 #6410

merged 2 commits into from
Jul 29, 2022

Conversation

kyletsang
Copy link
Member

@kyletsang kyletsang commented Jul 25, 2022 •
edited

Fixes #6399

Updates our search to use DocSearch v3. I've kept the default styles for now, we can tweak later if needed.

Preview: https://deploy-preview-6410--react-bootstrap.netlify.app/

golota60
golota60 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@golota60 golota60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome, but don't we want the search input to take the entire width?
e.g.
image
^ (this has width: 100%, margin-right: 16px on button)
instead of
image

@kyletsang
Copy link
Member Author

Made the changes @golota60 , thanks!

@kyletsang kyletsang merged commit f66cf79 into master Jul 29, 2022
@kyletsang kyletsang deleted the algolia-v3 branch July 29, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golota60 golota60 golota60 approved these changes

@jquense jquense Awaiting requested review from jquense

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kyletsang @golota60