Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlayTrigger with defaultShow does not position tooltip correctly #6619 #6647

Closed
wants to merge 1 commit into from

Conversation

Emanib
Copy link

@Emanib Emanib commented Jun 30, 2023

No description provided.

@Emanib Emanib changed the title fix show default overlay trigger OverlayTrigger with defaultShow does not position tooltip correctly #6619 Jun 30, 2023
@Emanib
Copy link
Author

Emanib commented Jun 30, 2023

Fix issue #6619
In this issue, #6619 The default show for the tooltip in the overlay trigger is not visible.
Because triggerNodeRef.current is not passing in safeFindDOMNode

PART OF GTC OPEN SOURCE INTIATIVE

@kyletsang
Copy link
Member

safeFindDOMNode is already called here:

mergedRef(safeFindDOMNode(r));

This is what sets triggerNodeRef. The underlying issue is likely that popper isn't repositioning once the ref is resolved.

@jquense
Copy link
Member

jquense commented Jul 7, 2023

we really need to switch to a callback ref probably?

@kyletsang
Copy link
Member

Closed in favor of #6657

@kyletsang kyletsang closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants