fix(docs): compilation issues when building production files #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was due to `ownerDocument` using `document` when it wasn't defined (which is the case when building production files).
bpas247
commented
Aug 30, 2019
src/utils/useWaitForDOMRef.js
Outdated
| @@ -2,6 +2,7 @@ import ownerDocument from 'dom-helpers/ownerDocument'; | |||
| import { useState, useEffect } from 'react'; | |||
|
|
|||
| const resolveRef = ref => { | |||
| if(typeof document === 'undefined') return undefined; | |||
There was a problem hiding this comment.
So I'm pretty sure returning undefined here isn't the correct behavior for this use case, does anyone have a better suggestion for what to return here?
taion
approved these changes
Aug 30, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was due to
ownerDocumentusingdocumentwhen it wasn'tdefined (which is the case when building production files).