Use more robust method of getting dialog element #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
commented
Oct 20, 2017
|
|
||
| it('should not attempt to focus nonexistent children', () => { | ||
| const Dialog = () => null; |
There was a problem hiding this comment.
The old logic found some weird container <div> (maybe from a transition or something?) as the dialog element, instead of picking up on there not being any dialog element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note base branch.
Mostly fixes react-bootstrap/react-bootstrap#2600
Ref https://github.com/react-bootstrap/react-overlays/pull/208/files#r142582319
Sorry for the random formatting changes on the tests. Got carried away.
Perhaps we should still check for
.hasAttributeondialogElement, though – in the case where it's e.g. a text node, the dialog element will just be a string and thus won't have that method.