#68 don't close RootCloseWrapper on right clicks #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| simulant.fire(document.getElementById('my-div'), 'click', {button: 1}); | ||
|
|
||
| expect(spy).to.have.been.called; |
| @@ -10,6 +10,14 @@ const CLICK_WAS_INSIDE = '__click_was_inside'; | |||
|
|
|||
| let counter = 0; | |||
|
|
|||
| function isLeftClickEvent(event) { | |||
| return event.button === 0 | |||
There was a problem hiding this comment.
NIT: Do we use semicolons in this repo?
There was a problem hiding this comment.
Why so strict when semicolon insertion keeps you safe? :-)
http://www.ecma-international.org/ecma-262/5.1/#sec-7.9
There was a problem hiding this comment.
Yes, but we still want consistency in code style.
|
LGTM |
|
LGTM. @adamziel mind squashing? |
|
@taion squash :-) |
|
I'll squash and merge by hand then. |
|
Merged in f1528af. |
|
@jquense Can this be v0.6.1? |
|
sure, no time to release now tho for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #68