Fix yarnpkg alias usage in the init script #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite what the comment said we were printing "Installing dependencies using yarnpkg..." yet installing them using `yarn`. Turn it the other way around and print "Installing dependencies using yarn..." but use the `yarnpkg` alias so we can avoid issues like facebook/create-react-app#1257 (Hadoop has a `yarn` command!)
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite what the comment said we were printing "Installing dependencies using yarnpkg..." yet installing them using
yarn.Turn it the other way around and print "Installing dependencies using yarn..." but use the
yarnpkgalias so we can avoid issues like facebook/create-react-app#1257. (Hadoop has ayarncommand!)