Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Picker): merge two focus #519

Closed
wants to merge 1 commit into from

Conversation

Yangzhedi
Copy link

fix #11249
merge two focus into one focus

@ant-design-bot
Copy link

Deploy preview for rc-calendar failed.

Built with commit 94a7ffa

https://app.netlify.com/sites/rc-calendar/deploys/5c75f5f5e1415500088a381a

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #519 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #519   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files          10       10           
  Lines         688      688           
  Branches      198      198           
=======================================
  Hits          615      615           
  Misses         63       63           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856f781...94a7ffa. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Feb 27, 2019

We should handle onFocus instead of change focus target...

@Yangzhedi
Copy link
Author

😂

@Yangzhedi Yangzhedi closed this Feb 27, 2019
@Yangzhedi
Copy link
Author

onFocus is bind on span which wrapped Picker,
https://github.com/ant-design/ant-design/blob/master/components/date-picker/createPicker.tsx#L246
onFocus={props.onFocus} , how to merge the focus ?

@zombieJ
Copy link
Member

zombieJ commented Feb 27, 2019

onFocus = this.onFocus and do wrap logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker is calling onFocus/onBlur two times
3 participants