Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix react lifecycle warning #650

Merged
merged 1 commit into from Dec 25, 2019
Merged

fix react lifecycle warning #650

merged 1 commit into from Dec 25, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 25, 2019

@afc163 afc163 changed the base branch from master to 9.x December 25, 2019 02:23
@codecov
Copy link

codecov bot commented Dec 25, 2019

Codecov Report

Merging #650 into 9.x will decrease coverage by 0.13%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##              9.x     #650      +/-   ##
==========================================
- Coverage   90.78%   90.64%   -0.14%     
==========================================
  Files          10       10              
  Lines         716      716              
  Branches      214      214              
==========================================
- Hits          650      649       -1     
- Misses         57       58       +1     
  Partials        9        9
Impacted Files Coverage Δ
src/month/MonthTable.js 87.5% <80%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cabf95...eabd866. Read the comment docs.

@afc163 afc163 merged commit be0b143 into 9.x Dec 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-lifecycle-warning branch December 25, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant