-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set 'id' attribute to the panel #69
Comments
Nope, just use: <Panel>
<div id="..."></div>
</Panel> |
@shepherdwind I am not sure if we can pass rest props to panel? Lines 14 to 22 in f6ea09b
|
@benjycui sure I can set id on the content of the panel. I would be nice to have an id of the panel itself, as it can simplify, for example, UI tests. |
nope. There should never be a id api,but we may consider pass down rest props |
Rest props pass to panel is ok. But, I think that React will throw error when pass an unknown prop to panel. |
IMO, This is not our concern, we just need to make sure all api which shown in doc are handled, then rest props should be all html valiad. |
@benjycui Any hope on resolving this issue anytime soon? |
ping @shepherdwind |
Pass rest props to panel div will give it too much useless prop. So, The only way is to add a prop id , see mr #72 |
1.7.6 |
Is there any way to set id attribute to the panel?
The text was updated successfully, but these errors were encountered: