Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modals attached to body #48

Closed
afc163 opened this issue Jan 15, 2017 · 1 comment
Closed

Modals attached to body #48

afc163 opened this issue Jan 15, 2017 · 1 comment

Comments

@afc163
Copy link
Member

afc163 commented Jan 15, 2017 •
edited
Loading

Hi, currently Modals are attached to the body, which is an issue if you do serverside rendering. Wouldn't it be a better approach to use or imitate https://github.com/cloudflare/react-gateway, in that you choose a destination inside your app component (which works great for SSR)?

Move from ant-design/ant-design#3731 by @bkniffler
@afc163 afc163 mentioned this issue Jan 15, 2017
Closed
@eternalsky
Copy link

similar case, Can Modal provide getContainer config to support a custom container instead of just using a div (which can not be modified) attached to body?

@bkniffler bkniffler mentioned this issue Mar 23, 2017
Closed
yesmeck referenced this issue Sep 20, 2017
@benjycui
feat: support Dialog[getContainer]
1dc1c55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@afc163 @benjycui @eternalsky