Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modals attached to body #3731

Closed
bkniffler opened this issue Nov 4, 2016 · 2 comments
Closed

Modals attached to body #3731

bkniffler opened this issue Nov 4, 2016 · 2 comments
Assignees
@yiminghe

Comments

@bkniffler
Copy link

Hi, currently Modals are attached to the body, which is an issue if you do serverside rendering. Wouldn't it be a better approach to use or imitate https://github.com/cloudflare/react-gateway, in that you choose a destination inside your app component (which works great for SSR)?
@afc163 afc163 mentioned this issue Jan 15, 2017
Closed
@afc163
Copy link
Member

afc163 commented Jan 15, 2017

trace react-component/dialog#48

@afc163 afc163 closed this as completed Jan 15, 2017
@lock
Copy link

lock bot commented May 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yiminghe yiminghe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yiminghe @afc163 @bkniffler