Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use useId to sync snapshot in test env #286

Merged
merged 1 commit into from
Apr 18, 2022
Merged

refactor: Use useId to sync snapshot in test env #286

merged 1 commit into from
Apr 18, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 18, 2022

修复 Dialog 跨 React 版本的 snapshot 问题
ref ant-design/ant-design#35026

@vercel
Copy link

vercel bot commented Apr 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dialog ✅ Ready (Inspect) Visit Preview Apr 18, 2022 at 6:23AM (UTC)

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #286 (f13acf8) into master (8adf763) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   98.12%   98.05%   -0.08%     
==========================================
  Files           6        6              
  Lines         160      154       -6     
  Branches       47       46       -1     
==========================================
- Hits          157      151       -6     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
src/util.ts 100.00% <ø> (ø)
src/Dialog/index.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zombieJ zombieJ merged commit a7f2c70 into master Apr 18, 2022
@zombieJ zombieJ deleted the useId branch April 18, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant