Fix prop-types and create-react-class warning #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paranoidjk
reviewed
Apr 18, 2017
src/Dialog.tsx
Outdated
| @@ -49,7 +50,8 @@ function offset(el) { | |||
| return pos; | |||
| } | |||
|
|
|||
| const Dialog = React.createClass<IDialogPropTypes, any>({ | |||
| const Dialog = createReactClass<IDialogPropTypes, any>({ | |||
|
CI is broken |
|
ci 看起来是 PhantomJS 不支持es6，@benjycui 看下测试 |
这不大可能吧，毕竟测试都会经过编译。 |
|
重新跑下 CI 吧，我没权限。 |
|
ci 挂了 |
|
由于某些复杂的原因。。。重新发了个一模一样的pr #59 这个关掉了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-design/ant-design#5678