feat: refactor fn #244
Closed
feat: refactor fn #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
- Coverage 73.97% 73.58% -0.40%
==========================================
Files 3 3
Lines 392 371 -21
Branches 160 159 -1
==========================================
- Hits 290 273 -17
+ Misses 102 98 -4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
zombieJ
reviewed
May 9, 2022
| const maskDom = useRef<HTMLDivElement>(null); | ||
| const handlerDom = useRef<HTMLDivElement>(null); | ||
| const drawerId = useRef<string>(); | ||
| const startPos = useRef<Point>(null); |
There was a problem hiding this comment.
hmm...这些 useRef 可以改成 useState 不？纯改成 useRef 就没有 FC 的优势了
There was a problem hiding this comment.
目前单纯改写法， 看看后面用 rc-motion 重构还需不需要这些变量吧
zombieJ
reviewed
May 9, 2022
| }; | ||
| const childProps = omit({ ...defaultProps, ...props }, [ |
There was a problem hiding this comment.
这个需要挪到上面去，props 本身就通过解构合并起来。否则重构很容易采坑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.