Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent scroll when drawer close and focus #417

Merged
merged 1 commit into from
May 27, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 27, 2023

防止 Drawer 关闭时重新聚焦触发元素时页面滚动。

参考:https://github.com/react-component/dialog/blob/646efc72f199818ac88d3b4567b64eb9a2c62b2e/src/Dialog/index.tsx#L78

@vercel
Copy link

vercel bot commented May 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
drawer ❌ Failed (Inspect) May 27, 2023 10:07am

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #417 (12532d7) into master (94a9e58) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 12532d7 differs from pull request most recent head 0d96b3d. Consider uploading reports for the commit 0d96b3d to get more accurate results

@@            Coverage Diff            @@
##            master      #417   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          134       140    +6     
  Branches        51        53    +2     
=========================================
+ Hits           134       140    +6     
Impacted Files Coverage Δ
src/Drawer.tsx 100.00% <100.00%> (ø)
src/util.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afc163 afc163 merged commit 962dfc4 into master May 27, 2023
6 of 7 checks passed
@afc163 afc163 deleted the fix/drawer-focus-scroll branch May 27, 2023 10:12
@afc163
Copy link
Member Author

afc163 commented May 27, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant