Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest to revert react-lifecycles-compat #37

Closed
zation opened this issue Apr 24, 2018 · 1 comment
Closed

Suggest to revert react-lifecycles-compat #37

zation opened this issue Apr 24, 2018 · 1 comment

Comments

@zation
Copy link

zation commented Apr 24, 2018

I think this package doesn't usage any new lifecycle api (getDerivedStateFromProps, getSnapshotBeforeUpdate)? So react-lifecycles-compat may be unnecessary. Besides, there still has some problem when using react-lifecycles-compat: reactjs/react-lifecycles-compat#13
@zation zation closed this as completed Apr 24, 2018
@zation
Copy link
Author

zation commented Apr 24, 2018

Ignore, I didn't notice there is getDerivedStateFromProps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zation