Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for infinite field nesting on return object #46

Closed
wants to merge 2 commits into from
Closed

allow for infinite field nesting on return object #46

wants to merge 2 commits into from

Conversation

alexggordon
Copy link

Initially, when looking through the issues that were allowing nesting of fields, I had found this issue that allowed for something along the lines of

 {...getFieldProps('normal.a', {
   valuePropName: 'checked',
 })}

However, I had expected to be able to also do 'normal.a.b.c' and have that object returned. Apparently that is not the case. This remedies this, with a hard limit of 100 levels deep on an object.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 87.5% when pulling 90109f8 on alexggordon:infinite-field-nesting into 616ddd3 on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 87.212% when pulling 3c7fa1f on alexggordon:infinite-field-nesting into 616ddd3 on react-component:master.

@williamkhshea
Copy link
Contributor

@alexggordon FWIW, I am going to submit a PR that will support complex nested objects and arrays (e.g. a.b[0].c[0], a[1][2].b.c, etc.).

@alexggordon
Copy link
Author

closed in favor of #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants