Fix onKeyUp, close ant-design/ant-design#4717

react-component · Jan 25, 2017 · 998b124 · 998b124
1 parent 74ab28e
commit 998b124
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,6 +1,14 @@
 # History
 ----
 
+## 3.0.2
+
+- Fix `onKeyUp`.
+
+## 3.0.1
+
+- Fix invalid input like '11x'.
+
 ## 3.0.0
 
 - Trigger onChange when user input

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rc-input-number",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "input-number ui component for react(web & react-native)",
   "keywords": [
     "react",

diff --git a/src/index.js b/src/index.js
@@ -15,6 +15,7 @@ const InputNumber = React.createClass({
     focusOnUpDown: PropTypes.bool,
     onChange: PropTypes.func,
     onKeyDown: PropTypes.func,
+    onKeyUp: PropTypes.func,
     prefixCls: PropTypes.string,
     disabled: PropTypes.bool,
     onFocus: PropTypes.func,
@@ -55,7 +56,18 @@ const InputNumber = React.createClass({
     } else if (e.keyCode === 40) {
       this.down(e);
     }
-    this.props.onKeyDown(e, ...args);
+    const { onKeyDown } = this.props;
+    if (onKeyDown) {
+      onKeyDown(e, ...args);
+    }
+  },
+
+  onKeyUp(e, ...args) {
+    this.stop();
+    const { onKeyUp } = this.props;
+    if (onKeyUp) {
+      onKeyUp(e, ...args);
+    }
   },
 
   getValueFromEvent(e) {
@@ -157,7 +169,7 @@ const InputNumber = React.createClass({
             onFocus={this.onFocus}
             onBlur={this.onBlur}
             onKeyDown={this.onKeyDown}
-            onKeyUp={this.stop}
+            onKeyUp={this.onKeyUp}
             autoFocus={props.autoFocus}
             readOnly={props.readOnly}
             disabled={props.disabled}