feat: trigger props.onStep when value stepps up/down #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/input-number/jdiwzcv23 |
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 92.99% 93.01% +0.01%
==========================================
Files 1 1
Lines 371 372 +1
Branches 134 135 +1
==========================================
+ Hits 345 346 +1
Misses 26 26
Continue to review full report at Codecov.
|
zombieJ
reviewed
Oct 9, 2020
src/InputNumber.tsx
Outdated
| @@ -613,6 +613,7 @@ class InputNumber extends React.Component<Partial<InputNumberProps>, InputNumber | |||
| val = props.min; | |||
| } | |||
| this.setValue(val, null); | |||
| if (props.onStep) props.onStep(type, val); | |||
There was a problem hiding this comment.
onStep(value, info: { offset: number, type: 'up' | 'down' })
|
|
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to tell the source of the value change
In certain scenarios, such as Yuque Show, value changes are only necessary to handle in following cases:
props.onChange triggers too often since any temporary edits change value.