code optimization.

react-component · Aug 23, 2017 · 030e087 · 030e087
1 parent 47ed48f
commit 030e087
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 10 deletions.
diff --git a/src/DatePicker.base.tsx b/src/DatePicker.base.tsx
@@ -224,7 +224,7 @@ export default abstract class DatePicker extends React.PureComponent<PropsType,
         }
     }
 
-    computeVisible = (fullHeight: number, clientHeight: number, scrollTop: number) => {
+    computeVisible = (clientHeight: number, scrollTop: number) => {
         let needUpdate = false;
         const MAX_VIEW_PORT = clientHeight * 2;
         const MIN_VIEW_PORT = clientHeight;
@@ -273,11 +273,10 @@ export default abstract class DatePicker extends React.PureComponent<PropsType,
 
     createOnScroll = () => {
         let timer: any;
-        let fullHeight = 0, clientHeight = 0, scrollTop = 0;
+        let clientHeight = 0, scrollTop = 0;
 
         return (data: { full: number, client: number, top: number }) => {
-            const { full, client, top } = data;
-            fullHeight = full;
+            const { client, top } = data;
             clientHeight = client;
             scrollTop = top;
 
@@ -287,14 +286,14 @@ export default abstract class DatePicker extends React.PureComponent<PropsType,
 
             timer = setTimeout(() => {
                 timer = undefined;
-                if (this.computeVisible(fullHeight, clientHeight, scrollTop)) {
+                if (this.computeVisible(clientHeight, scrollTop)) {
                     this.forceUpdate();
                 }
             }, 64);
         };
     }
 
-    onCellClick = (day: Models.CellData, monthData: Models.MonthData) => {
+    onCellClick = (day: Models.CellData) => {
         if (!day.tick) return;
         this.props.onCellClick && this.props.onCellClick(new Date(day.tick));
     }

diff --git a/src/DatePicker.tsx b/src/DatePicker.tsx
@@ -56,7 +56,7 @@ export default class DatePicker extends Component {
 
                     this.visibleMonth = this.visibleMonth.slice(0, this.props.initalMonths);
 
-                    this.state.months.forEach((m, index) => {
+                    this.state.months.forEach((m) => {
                         m.updateLayout && m.updateLayout();
                     });
 
@@ -88,7 +88,7 @@ export default class DatePicker extends Component {
                         }
                         <div className="months">
                             {
-                                this.state.months.map((m, index) => {
+                                this.state.months.map((m) => {
                                     const hidden = m.height && this.visibleMonth.indexOf(m) < 0;
                                     if (hidden) {
                                         return <div key={m.title + '_shallow'} style={{ height: m.height }}></div>;

diff --git a/src/calendar/AnimateWrapper.tsx b/src/calendar/AnimateWrapper.tsx
@@ -1,6 +1,6 @@
 import React from 'react';
 
-interface PropsType {
+export interface PropsType {
     visible: boolean;
     className?: string;
     displayType?: string;

diff --git a/src/calendar/ShortcutPanel.tsx b/src/calendar/ShortcutPanel.tsx
@@ -1,6 +1,6 @@
 import * as React from 'react';
 
-interface PropsType {
+export interface PropsType {
     locale: GlobalModels.Locale;
     onSelect: (startDate?: Date, endDate?: Date) => void;
 }