Remove moment #31
Merged
Remove moment #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
未考虑 UTC 时间，时区要靠用户自己调整 |
paranoidjk
reviewed
Jul 14, 2017
src/DatePicker.tsx
Outdated
| } | ||
| } else if (mode === DATE) { | ||
| if (date.isBefore(minDate, 'day')) { | ||
| return minDate.clone(); | ||
| if (+date + 24 * 60 * 60 * 1000 <= minDate) { |
There was a problem hiding this comment.
string + number < Date Object ?
There was a problem hiding this comment.
忘了，后边 minDate 也需要个前置 +
There was a problem hiding this comment.
貌似不转换没关系，Date Object > number正常、应该支持隐式自动转换
benjycui
reviewed
Jul 14, 2017
src/DatePicker.tsx
Outdated
| } | ||
| } else if (mode === DATE) { | ||
| if (date.isBefore(minDate, 'day')) { | ||
| return minDate.clone(); | ||
| if (+date + 24 * 60 * 60 * 1000 <= minDate) { |
There was a problem hiding this comment.
const ONE_DAY = 24 * 60 * 60 * 1000;
|
代码逻辑看不出什么问题，只是从风格而言，有比较多的隐式转换的地方。 |
此类问题，或者可以让用户通过 data-fns 和 moment 之类解决？ const time = moment().utcOffset(8);
<MDatePicker value={time.toDate()} /> |
|
又查了下，UTC 时间可以不用考虑，跟 local time 主要就是差了个时区，其他没什么 |
|
CI failed... |
yiminghe
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove moment.js