Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove allowSyntheticDefaultImports #61

Merged
merged 3 commits into from Apr 3, 2019
Merged

remove allowSyntheticDefaultImports #61

merged 3 commits into from Apr 3, 2019

Conversation

doxiaodong
Copy link
Collaborator

@coveralls
Copy link

coveralls commented May 7, 2018

Coverage Status

Coverage remained the same at 54.774% when pulling 186f3c4 on typings into c11b93c on master.

@doxiaodong
Copy link
Collaborator Author

doxiaodong commented May 7, 2018

  1. @types/react-native@types/node, lib.es6 的类型定义存在重复,参考 @types/react-native definitions for global and require conflict with @types/node DefinitelyTyped/DefinitelyTyped#16825

  2. 需不需要把 @types/react 等写进 peerDependencies

paranoidjk added a commit to react-component/swipeout that referenced this pull request Jun 12, 2018
@paranoidjk
Copy link
Member

这个问题所有用到 rn 的库都有,可以统一看下解决掉 react-component/swipeout@fd1e7b5

@doxiaodong
Copy link
Collaborator Author

doxiaodong commented Jun 27, 2018

@yesmeck babel-runtime 依赖都改了,然后 @types/classnames 并没有 default 导出,所以我还是觉得写成 import * as classname from 'classnames' 比较好, https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/classnames/index.d.ts

@yesmeck
Copy link
Member

yesmeck commented Jun 27, 2018

@doxiaodong ok

@doxiaodong doxiaodong merged commit 6c978b0 into master Apr 3, 2019
ToSky0515 added a commit to ToSky0515/swipeout-react that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants