Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize logic of default motion #328

Merged
merged 1 commit into from Jul 1, 2020
Merged

chore: optimize logic of default motion #328

merged 1 commit into from Jul 1, 2020

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Jul 1, 2020

@zombieJ @afc163 修改了默认 motion 逻辑、添加了导出 props,看看没问题的话再发一下,我在 antd 里再测测。

@kerm1it kerm1it changed the title chore: optimize logic of default motion; chore: optimize logic of default motion Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #328 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   95.34%   95.36%   +0.02%     
==========================================
  Files          11       11              
  Lines         880      884       +4     
  Branches      261      263       +2     
==========================================
+ Hits          839      843       +4     
  Misses         41       41              
Impacted Files Coverage Δ
src/Menu.tsx 98.11% <ø> (ø)
src/utils/legacyUtil.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a530b15...9150d8b. Read the comment docs.

@kerm1it
Copy link
Member Author

kerm1it commented Jul 1, 2020

优化效果:

之前:

Jul-01-2020 21-03-07

之后:

Jul-01-2020 21-02-55

@zombieJ zombieJ merged commit cf18305 into react-component:master Jul 1, 2020
@zombieJ
Copy link
Member

zombieJ commented Jul 1, 2020

+ rc-menu@8.4.0-alpha.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants