Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove animation span #17

Merged
merged 4 commits into from
May 30, 2017
Merged

Remove animation span #17

merged 4 commits into from
May 30, 2017

Conversation

paranoidjk
Copy link
Member

No description provided.

@paranoidjk
Copy link
Member Author

@afc163 fixed. 之前没注意到 antd 会有多个同时存在多个 notification 的情况。

@paranoidjk paranoidjk requested a review from afc163 May 30, 2017 11:08
@paranoidjk paranoidjk changed the title [WIP] Remove animation span Remove animation span May 30, 2017
@afc163
Copy link
Member

afc163 commented May 30, 2017

可以补个用例。

@paranoidjk
Copy link
Member Author

updated.

@afc163 afc163 merged commit 901bda6 into master May 30, 2017
@benjycui benjycui deleted the remove-animation-span branch June 9, 2017 02:10
afc163 referenced this pull request in ant-design/ant-design Jul 7, 2017
const animateProps = {};
if (this.state.notices.length <= 1) {
animateProps.component = '';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afc163 added a commit that referenced this pull request Jul 7, 2017
afc163 added a commit to ant-design/ant-design-mobile that referenced this pull request Jul 7, 2017
paranoidjk pushed a commit to ant-design/ant-design-mobile that referenced this pull request Jul 8, 2017
cncolder pushed a commit to cncolder/ant-design-mobile that referenced this pull request Jul 12, 2017
cncolder pushed a commit to cncolder/ant-design-mobile that referenced this pull request Jul 12, 2017
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants