shouldnot always call setState on handleKeyUp func (#98)

react-component · Aug 3, 2017 · 8a057c3 · 8a057c3
1 parent bd676fd
commit 8a057c3
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/Pagination.jsx b/src/Pagination.jsx
@@ -134,19 +134,22 @@ export default class Pagination extends React.Component {
 
   handleKeyUp = (e) => {
     const inputValue = e.target.value;
+    const currentInputValue = this.state.currentInputValue;
     let value;
 
     if (inputValue === '') {
       value = inputValue;
     } else if (isNaN(Number(inputValue))) {
-      value = this.state.currentInputValue;
+      value = currentInputValue;
     } else {
       value = Number(inputValue);
     }
 
-    this.setState({
-      currentInputValue: value,
-    });
+    if (value !== currentInputValue) {
+      this.setState({
+        currentInputValue: value,
+      });
+    }
 
     if (e.keyCode === KEYCODE.ENTER) {
       this.handleChange(value);