fix: quick jump render logic (#553)

* test: add unit test case * fix: quick jump render logic ref: ant-design/ant-design#46671 * test: fix demo test error * chore: update demo * chore: update snap * test: add unit test case * fix: simple quick jumper custom goButton bug
react-component · Dec 28, 2023 · ba13760 · ba13760 · vercel · Dec 28, 2023
1 parent 455c92a
commit ba13760
Show file tree

Hide file tree

Showing 6 changed files with 3,598 additions and 1,036 deletions.
diff --git a/docs/examples/simple.tsx b/docs/examples/simple.tsx
@@ -32,6 +32,18 @@ export default () => {
         showSizeChanger
         selectComponentClass={Select}
       />
+      <hr />
+      <a href="https://github.com/ant-design/ant-design/issues/46671">
+        Antd #46671
+      </a>
+      <Pagination
+        simple
+        defaultCurrent={1}
+        total={50}
+        showSizeChanger
+        showQuickJumper
+        selectComponentClass={Select}
+      />
     </>
   );
 };
diff --git a/src/Pagination.tsx b/src/Pagination.tsx
@@ -348,27 +348,32 @@ const Pagination: React.FC<PaginationProps> = (props) => {
   let simplePager: React.ReactNode = null;
 
   if (simple) {
-    if (typeof goButton === 'boolean') {
+    // ====== Simple quick jump ======
+    if (goButton) {
+      if (typeof goButton === 'boolean') {
+        gotoButton = (
+          <button type="button" onClick={handleGoTO} onKeyUp={handleGoTO}>
+            {locale.jump_to_confirm}
+          </button>
+        );
+      } else {
+        gotoButton = (
+          <span onClick={handleGoTO} onKeyUp={handleGoTO}>
+            {goButton}
+          </span>
+        );
+      }
+
       gotoButton = (
-        <button type="button" onClick={handleGoTO} onKeyUp={handleGoTO}>
-          {locale.jump_to_confirm}
-        </button>
+        <li
+          title={showTitle ? `${locale.jump_to}${current}/${allPages}` : null}
+          className={`${prefixCls}-simple-pager`}
+        >
+          {gotoButton}
+        </li>
       );
-    } else {
-      <span onClick={handleGoTO} onKeyUp={handleGoTO}>
-        {goButton}
-      </span>;
     }
 
-    gotoButton = (
-      <li
-        title={showTitle ? `${locale.jump_to}${current}/${allPages}` : null}
-        className={`${prefixCls}-simple-pager`}
-      >
-        {gotoButton}
-      </li>
-    );
-
     simplePager = (
       <li
         title={showTitle ? `${current}/${allPages}` : null}