Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: itemRender do not display empty elements #527

Merged
merged 9 commits into from
Aug 15, 2023

Conversation

spencer17x
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ❌ Failed (Inspect) Aug 14, 2023 9:51am

src/Pager.tsx Outdated Show resolved Hide resolved
src/Pagination.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #527 (4ca725d) into master (3059cb8) will increase coverage by 0.39%.
Report is 1 commits behind head on master.
The diff coverage is 92.59%.

❗ Current head 4ca725d differs from pull request most recent head ad92366. Consider uploading reports for the commit ad92366 to get more accurate results

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
+ Coverage   92.73%   93.13%   +0.39%     
==========================================
  Files           4        4              
  Lines         344      364      +20     
  Branches      121      135      +14     
==========================================
+ Hits          319      339      +20     
+ Misses         25       24       -1     
- Partials        0        1       +1     
Files Changed Coverage Δ
src/Pagination.tsx 92.25% <92.00%> (+0.52%) ⬆️
src/Pager.tsx 91.66% <100.00%> (+1.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/Pager.tsx Show resolved Hide resolved
@spencer17x
Copy link
Contributor Author

@afc163

@afc163
Copy link
Member

afc163 commented Jul 17, 2023

+1

src/Pagination.tsx Outdated Show resolved Hide resolved
src/Pagination.tsx Outdated Show resolved Hide resolved
Co-authored-by: afc163 <afc163@gmail.com>
@spencer17x
Copy link
Contributor Author

@afc163

src/Pagination.tsx Outdated Show resolved Hide resolved
src/Pagination.tsx Outdated Show resolved Hide resolved
src/Pagination.tsx Outdated Show resolved Hide resolved
src/Pager.tsx Show resolved Hide resolved
@zombieJ zombieJ merged commit e08aaa3 into react-component:master Aug 15, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants