Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add less pages option for less total element mobile #55

Merged
merged 1 commit into from
Feb 7, 2017

Conversation

evilcat-x
Copy link
Contributor

lessPage will set the buffer size to 3 rather than 5, ( 1 page to each
side ) which reduce the total number of <li> element from 11 to 9.

移动端上 中间5个页面感觉太多了, 3个还好, 感觉还可以加一个隐藏上一页下一页 的选项 这样 就是
1 ••• 3 4 5 ••• 7 这样的长宽比 可以直接在手机上用

看之前issue 都是直接要求pull request 我就直接fork了下 如果命名需要改什么的我再去改

lessPage will set the buffer size to 3 rather than 5, ( 1 page to each
side ) which reduce the total number of `<li>` element from 11 to 9.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 78.481% when pulling 5b923e0 on Evilcat325:master into 8dcc742 on react-component:master.

@afc163
Copy link
Member

afc163 commented Feb 3, 2017

ant-design/ant-design@0d0d63a

也许这样就够了。

@evilcat-x
Copy link
Contributor Author

但是如果不能减少中间的数量 那手机上看还是 1 ••• 3 4 5 7 8 ••• 10 然而这个 跳过一页的功能 并没有多少人会用 1 ••• 3 4 5 ••• 7 的排版 相当于 首页 快速后退 上一页 当前页面 下一页 快速前进 末页

@afc163 afc163 merged commit b621778 into react-component:master Feb 7, 2017
@afc163
Copy link
Member

afc163 commented Feb 7, 2017

Thx!

@afc163
Copy link
Member

afc163 commented Feb 7, 2017

I renamed lessPages to showLessItems.

@evilcat-x
Copy link
Contributor Author

thx! I totally agree that showLessItems is a better name. lol, I'm so bad at contributing variable names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants