Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prop align #569

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

coding-ice
Copy link
Contributor

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 5:54am

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (b89cb0e) to head (649cc31).

❗ Current head 649cc31 differs from pull request most recent head 884278f. Consider uploading reports for the commit 884278f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #569   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files           3        3           
  Lines         310      310           
  Branches      137      137           
=======================================
  Hits          306      306           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coding-ice
Copy link
Contributor Author

@yoyo837 大佬,这个麻烦review一下~

<>
<Pagination direction="start" />
<Pagination direction="center" />
<Pagination direction="end" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

direction 容易和 rtl 混淆,叫 align="xxx" 如何?

Copy link
Member

@afc163 afc163 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs 也用的 align。

src/Pagination.tsx Outdated Show resolved Hide resolved
@afc163 afc163 merged commit 53ad263 into react-component:master May 14, 2024
9 checks passed
@afc163
Copy link
Member

afc163 commented May 23, 2024

antd 里也需要加一下。

@coding-ice
Copy link
Contributor Author

coding-ice commented May 23, 2024

antd 里也需要加一下。

请教一下,这个需要等到发版本以后吗,目前为止还没发版
image

@afc163
Copy link
Member

afc163 commented May 23, 2024

@afc163 afc163 changed the title feat: add prop direction feat: add prop align Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants