Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing shortweekdays and shortmonths for date-fns #126

Closed
wants to merge 2 commits into from
Closed

Fix missing shortweekdays and shortmonths for date-fns #126

wants to merge 2 commits into from

Conversation

jperelli
Copy link

This PR fixes empty month pickers and missing weekday names in daypicker when using with date-fns

image
image

@vercel
Copy link

vercel bot commented Aug 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/bs1eovia1
✅ Preview: https://picker-git-fork-jperelli-master.react-component.vercel.app

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #126 into master will decrease coverage by 0.30%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   99.59%   99.29%   -0.31%     
==========================================
  Files          45       45              
  Lines        1969     1978       +9     
  Branches      587      587              
==========================================
+ Hits         1961     1964       +3     
- Misses          6       12       +6     
  Partials        2        2              
Impacted Files Coverage Δ
src/generate/dateFns.ts 88.00% <33.33%> (-12.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5c27f...ed0e2bc. Read the comment docs.

@fgblomqvist
Copy link

fgblomqvist commented Aug 18, 2020

This is a duplicate of #115 (and I'd argue that #115's implementation is better). @afc163 wanna weigh in?

@jperelli
Copy link
Author

I agree, I did the PR without knowing the existence of the other one. Sometimes you don't have any pull request, sometimes you have 2 to choose 🤷

@afc163
Copy link
Member

afc163 commented Aug 19, 2020

@fireairforce

@jperelli
Copy link
Author

closing in favor of #115

@jperelli jperelli closed this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants