Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update GenerateConfig to make it immutable #42

Merged
merged 1 commit into from Mar 30, 2020
Merged

feat: Update GenerateConfig to make it immutable #42

merged 1 commit into from Mar 30, 2020

Conversation

iamkun
Copy link
Collaborator

@iamkun iamkun commented Mar 30, 2020

这个PR主要是修改了调用 moment API 时的写法,返回计算结果而不是其自身,更加贴近 immutable 的概念,也能让 https://www.npmjs.com/package/antd-dayjs-webpack-plugin 摆脱 badMutable 插件,真正实现 immutable

@vercel
Copy link

vercel bot commented Mar 30, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/picker/8h2ok6gza
✅ Preview: https://picker-git-fork-iamkun-master.react-component.now.sh

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #42 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   99.54%   99.54%   -0.01%     
==========================================
  Files          43       43              
  Lines        1773     1764       -9     
  Branches      518      519       +1     
==========================================
- Hits         1765     1756       -9     
  Misses          6        6              
  Partials        2        2
Impacted Files Coverage Δ
src/generate/moment.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09e842...cb474d1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants