Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add placeholder option for multiple picker #768

Closed

Conversation

nova1751
Copy link

@nova1751 nova1751 commented Mar 2, 2024

Related to ant-design/ant-design#47665. I add placeholder support for multiple date-picker, just like the rc-select component.

Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
picker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 1:24pm

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (ac9c87b) to head (a400d54).
Report is 3 commits behind head on master.

❗ Current head a400d54 differs from pull request most recent head b9ebab5. Consider uploading reports for the commit b9ebab5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #768   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          63       63           
  Lines        2542     2544    +2     
  Branches      701      677   -24     
=======================================
+ Hits         2506     2508    +2     
  Misses         33       33           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nova1751
Copy link
Author

nova1751 commented Mar 5, 2024

Hello, can anyone review the code? @zombieJ @afc163

@afc163 afc163 requested a review from zombieJ March 5, 2024 02:52
@nova1751
Copy link
Author

@zombieJ Hello, I think this PR solved the placeholder problem issue ant-design/ant-design#47665 mentioned. Could you review the code if you have time or should I close this PR?

@afc163
Copy link
Member

afc163 commented Mar 14, 2024

@zombieJ @MadCcc

@toFrankie
Copy link

有进展否?👀

@zombieJ
Copy link
Member

zombieJ commented Apr 16, 2024

OPS. Sorry I miss this PR. I've updated in #798 😂

@zombieJ zombieJ closed this Apr 16, 2024
@nova1751
Copy link
Author

OPS. Sorry I miss this PR. I've updated in #798 😂

OK, waste a little time, though😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants