Change to ES6 Classes and seperate PropTypes module #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t seem to know it. Also struggles with the way I've done the propTypes
…ator to keep eslint happy
wemyss
commented
Apr 20, 2017
| @@ -0,0 +1,16 @@ | |||
| const enhancer = WrappedComponent => class Progress extends WrappedComponent { | |||
| componentDidUpdate() { | |||
There was a problem hiding this comment.
I wanted to put the base propTypes and defaultProps in here but the linter cannot detect that there is a props validation for them
benjycui
reviewed
Apr 21, 2017
| @@ -1,35 +1,40 @@ | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
You should not disable all rules for the whole file.
There was a problem hiding this comment.
Sorry, I meant to have removed this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #22