Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compatible for nativeElement #191

Merged
merged 4 commits into from
Oct 20, 2023
Merged

feat: compatible for nativeElement #191

merged 4 commits into from
Oct 20, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 19, 2023

Support ref.current.nativeElement

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
resize-observer ❌ Failed (Inspect) Oct 19, 2023 9:57am

import findDOMNode from 'rc-util/lib/Dom/findDOMNode';
import { observe, unobserve } from '../utils/observerUtil';
import { supportRef, useComposeRef } from 'rc-util/lib/ref';
import * as React from 'react';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import sort 不加啊

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabric 里有,这个是它自动变的。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另开个 PR?

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #191 (6c633e0) into master (fe320b1) will decrease coverage by 5.76%.
The diff coverage is 100.00%.

❗ Current head 6c633e0 differs from pull request most recent head 2b3ec86. Consider uploading reports for the commit 2b3ec86 to get more accurate results

@@             Coverage Diff             @@
##            master     #191      +/-   ##
===========================================
- Coverage   100.00%   94.24%   -5.76%     
===========================================
  Files            5        6       +1     
  Lines          103      139      +36     
  Branches        30       42      +12     
===========================================
+ Hits           103      131      +28     
- Misses           0        7       +7     
- Partials         0        1       +1     
Files Coverage Δ
src/SingleObserver/index.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ merged commit ecc169b into master Oct 20, 2023
8 of 9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the nativeElement branch October 20, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants